| Index: trunk/phase3/tests/phpunit/TODO |
| — | — | @@ -1,9 +1,4 @@ |
| 2 | 2 | == Things To Do == |
| 3 | | - |
| 4 | | -* DEFAULT TESTS NEED TO MADE NON-DESTRUCTIVE. Any destructive tests which alter the contents of the live wiki need to |
| 5 | | -be protected with an explicit confirmation so people exploring their system don't accidentally destroy their main page |
| 6 | | -or register user accounts with default passwords. |
| 7 | | - |
| 8 | 3 | * Most of the tests are named poorly; naming should describe a use case in story-like language, not simply identify the |
| 9 | 4 | unit under test. An example would be the difference between testCalculate and testAddingIntegersTogetherWorks. |
| 10 | 5 | * Many of the tests make multiple assertions, and are thus not unitary tests. By using data-providers and more use-case |
| Index: trunk/phase3/tests/phpunit/includes/ArticleTablesTest.php |
| — | — | @@ -2,7 +2,6 @@ |
| 3 | 3 | |
| 4 | 4 | /** |
| 5 | 5 | * @group Database |
| 6 | | - * @group Destructive |
| 7 | 6 | */ |
| 8 | 7 | class ArticleTablesTest extends MediaWikiLangTestCase { |
| 9 | 8 | |
| Index: trunk/phase3/tests/phpunit/includes/api/ApiTest.php |
| — | — | @@ -2,7 +2,6 @@ |
| 3 | 3 | |
| 4 | 4 | /** |
| 5 | 5 | * @group Database |
| 6 | | - * @group Destructive |
| 7 | 6 | */ |
| 8 | 7 | class ApiTest extends ApiTestCase { |
| 9 | 8 | |
| Index: trunk/phase3/tests/phpunit/includes/api/ApiUploadTest.php |
| — | — | @@ -2,7 +2,6 @@ |
| 3 | 3 | |
| 4 | 4 | /** |
| 5 | 5 | * @group Database |
| 6 | | - * @group Destructive |
| 7 | 6 | */ |
| 8 | 7 | |
| 9 | 8 | /** |
| — | — | @@ -20,7 +19,6 @@ |
| 21 | 20 | |
| 22 | 21 | /** |
| 23 | 22 | * @group Database |
| 24 | | - * @group Destructive |
| 25 | 23 | * |
| 26 | 24 | * This is pretty sucky... needs to be prettified. |
| 27 | 25 | */ |
| Index: trunk/phase3/tests/phpunit/includes/api/ApiWatchTest.php |
| — | — | @@ -2,7 +2,6 @@ |
| 3 | 3 | |
| 4 | 4 | /** |
| 5 | 5 | * @group Database |
| 6 | | - * @group Destructive |
| 7 | 6 | * @todo This test suite is severly broken and need a full review |
| 8 | 7 | */ |
| 9 | 8 | class ApiWatchTest extends ApiTestCase { |
| Index: trunk/phase3/tests/phpunit/includes/api/ApiBlockTest.php |
| — | — | @@ -2,7 +2,6 @@ |
| 3 | 3 | |
| 4 | 4 | /** |
| 5 | 5 | * @group Database |
| 6 | | - * @group Destructive |
| 7 | 6 | */ |
| 8 | 7 | class ApiBlockTest extends ApiTestCase { |
| 9 | 8 | |