r91567 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91566‎ | r91567 | r91568 >
Date:17:27, 6 July 2011
Author:aaron
Status:ok
Tags:
Comment:
setFileVersion (r91435) was missing default $val
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -1307,10 +1307,11 @@
13081308 * @return Mixed: previous value
13091309 */
13101310 public function setFileVersion( $file ) {
 1311+ $val = null;
13111312 if ( $file instanceof File && $file->exists() ) {
13121313 $val = array( 'time' => $file->getTimestamp(), 'sha1' => $file->getSha1() );
13131314 }
1314 - return wfSetVar( $this->mFileVersion, $val );
 1315+ return wfSetVar( $this->mFileVersion, $val, true );
13151316 }
13161317
13171318 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91435* Added getFileVersion()/setFileVersion() functions to OutputPage...aaron05:23, 5 July 2011

Status & tagging log