r91511 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91510‎ | r91511 | r91512 >
Date:00:40, 6 July 2011
Author:reedy
Status:deferred
Tags:
Comment:
Comment out some stuff

Qualify column
Modified paths:
  • /trunk/extensions/MetricsReporting/ApiAnalyticsBase.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetricsReporting/ApiAnalyticsBase.php
@@ -102,7 +102,7 @@
103103 break;
104104 case 'selectprojects':
105105 // c
106 - $query['conds']['project_code'] = $parsedFilter;
 106+ $query['conds']['comscore_regions.project_code'] = $parsedFilter;
107107 break;
108108 case 'selectwikis':
109109 // c
@@ -136,8 +136,8 @@
137137 $data = array();
138138
139139 $fields = array_map( array( $this, 'getColumnName' ), $query['fields'] );
140 - $metricFields = $this->getMetricFields();
141 - $metricTotals = array();
 140+ //$metricFields = $this->getMetricFields();
 141+ //$metricTotals = array();
142142
143143 foreach( $res as $row ) {
144144 // Dump all data to output
@@ -148,12 +148,12 @@
149149 $data[] = $item;
150150
151151 // Do some maths
152 - foreach( $metricFields as $field ) {
153 - if ( !isset( $metricTotals[$field] ) ) {
154 - $metricTotals[$field] = 0;
155 - }
156 - $metricTotals[$field] += $row->$field;
157 - }
 152+ //foreach( $metricFields as $field ) {
 153+ // if ( !isset( $metricTotals[$field] ) ) {
 154+ // $metricTotals[$field] = 0;
 155+ // }
 156+ // $metricTotals[$field] += $row->$field;
 157+ //}
158158
159159 // Make grouped output data
160160 foreach( $this->getAllowedFilters() as $filter ) {
@@ -188,9 +188,9 @@
189189 }
190190
191191 $result->setIndexedTagName( $data, 'data' );
192 - $result->setIndexedTagName( $metricTotals, 'totals' );
 192+ //$result->setIndexedTagName( $metricTotals, 'totals' );
193193 $result->addValue( 'metric', $this->getModuleName(), $data );
194 - $result->addValue( 'totals', $this->getModuleName(), $metricTotals );
 194+ //$result->addValue( 'totals', $this->getModuleName(), $metricTotals );
195195 }
196196
197197 // TODO: Deal with foo AS bar, and return bar for nicer aliasing of stuff

Follow-up revisions

RevisionCommit summaryAuthorDate
r91513Followup r91511, qualify proper columnreedy01:07, 6 July 2011

Status & tagging log