r91513 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91512‎ | r91513 | r91514 >
Date:01:07, 6 July 2011
Author:reedy
Status:deferred
Tags:
Comment:
Followup r91511, qualify proper column
Modified paths:
  • /trunk/extensions/MetricsReporting/ApiAnalyticsBase.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetricsReporting/ApiAnalyticsBase.php
@@ -85,7 +85,7 @@
8686 switch ( $filter ) {
8787 case 'selectregions':
8888 // a, b, c
89 - $query['conds']['region_code'] = $parsedFilter;
 89+ $query['conds']['comscore_regions.region_code'] = $parsedFilter;
9090 break;
9191 case 'selectcountries':
9292 // b, c, d
@@ -102,7 +102,7 @@
103103 break;
104104 case 'selectprojects':
105105 // c
106 - $query['conds']['comscore_regions.project_code'] = $parsedFilter;
 106+ $query['conds']['project_code'] = $parsedFilter;
107107 break;
108108 case 'selectwikis':
109109 // c

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91511Comment out some stuff...reedy00:40, 6 July 2011

Status & tagging log