r91287 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91286‎ | r91287 | r91288 >
Date:20:31, 1 July 2011
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
fixing double encoding - bug 29668
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -658,10 +658,11 @@
659659 // jump to the correct section, because when we set the hash (#...)
660660 // the page won't reload...
661661 window.location.reload();
662 - } else {
663 - window.location = encodeURI(
 662+ } else { // not on user talk page
 663+ window.location =
 664+ // data.redirect.pageName has to be URL encoded but data.redirect.fragment is already encoded
664665 mw.config.get( 'wgArticlePath' ).replace( '$1', mw.util.wikiUrlencode( data.redirect.pageName ) )
665 - + '#' + data.redirect.fragment );
 666+ + '#' + data.redirect.fragment;
666667 }
667668 },
668669 error: function() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r91320fixing bug 29668 - WikiLove tab broken in Classic skinkaldari22:58, 1 July 2011
r91323follow-up to r91320, better fix for bug 29668 - WikiLove tab broken in Classi...kaldari23:14, 1 July 2011

Comments

#Comment by Krinkle (talk | contribs)   19:19, 5 July 2011

The commit looks good, so marking ok. Which bug did you mean though ?- bug 29668 seems a different one.

#Comment by Kaldari (talk | contribs)   19:22, 5 July 2011

Oops, this actually fixed bug 29670.

#Comment by Krinkle (talk | contribs)   19:29, 5 July 2011

Okay, cool.

Status & tagging log