r91323 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91322‎ | r91323 | r91324 >
Date:23:14, 1 July 2011
Author:kaldari
Status:ok
Tags:
Comment:
follow-up to r91320, better fix for bug 29668 - WikiLove tab broken in Classic skin
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -769,12 +769,12 @@
770770 * Init function which is called upon page load. Binds the WikiLove icon to opening the dialog.
771771 */
772772 init: function() {
773 - options = $.wikiLoveOptions;
 773+ options = $.wikiLoveOptions;
774774
775 - if ( mw.config.get( 'skin' ) == 'standard' ) {
 775+ if ( $( '#ca-wikilove' ).length ) {
 776+ var $wikiLoveLink = $( '#ca-wikilove' ).find( 'a' );
 777+ } else { // legacy skins
776778 var $wikiLoveLink = $( '#topbar a:contains(' + mw.msg( 'wikilove-tab-text' ) + ')' );
777 - } else {
778 - var $wikiLoveLink = $( '#ca-wikilove' ).find( 'a' );
779779 }
780780 $wikiLoveLink.unbind( 'click' );
781781 $wikiLoveLink.click( function( e ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91287fixing double encoding - bug 29668kaldari20:31, 1 July 2011
r91320fixing bug 29668 - WikiLove tab broken in Classic skinkaldari22:58, 1 July 2011

Status & tagging log