r91195 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91194‎ | r91195 | r91196 >
Date:18:38, 30 June 2011
Author:aaron
Status:reverted
Tags:
Comment:
Added normalizeSubpageLink() to DummyLinker. __call doesn't handle static function call attempts, __callStatic__ is PHP >= 5.3, and both clobber references anyway. Just added a wrapper function instead.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1997,9 +1997,12 @@
19981998 * @param $fname String Name of called method
19991999 * @param $args Array Arguments to the method
20002000 */
2001 - function __call( $fname, $args ) {
 2001+ public function __call( $fname, $args ) {
20022002 return call_user_func_array( array( 'Linker', $fname ), $args );
20032003 }
20042004
 2005+ public static function normalizeSubpageLink( $contextTitle, $target, &$text ) {
 2006+ return Linker::normalizeSubpageLink( $contextTitle, $target, $text );
 2007+ }
20052008 }
20062009

Follow-up revisions

RevisionCommit summaryAuthorDate
r91197Reverted r91195, this isn't needed ;)aaron18:45, 30 June 2011

Status & tagging log