r91196 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91195‎ | r91196 | r91197 >
Date:18:38, 30 June 2011
Author:reedy
Status:deferred
Tags:
Comment:
Always pass a db prefix of ''

Uncomment/set $wgMetricsDBtype to 'mysql'

Switch metric to be multi param for time being
Modified paths:
  • /trunk/extensions/MetricsReporting/ApiAnalytics.php (modified) (history)
  • /trunk/extensions/MetricsReporting/ApiAnalyticsBase.php (modified) (history)
  • /trunk/extensions/MetricsReporting/MetricsReporting.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetricsReporting/ApiAnalyticsBase.php
@@ -21,6 +21,7 @@
2222 'user' => $wgMetricsDBuser,
2323 'password' => $wgMetricsDBpassword,
2424 'dbname' => $wgMetricsDBname,
 25+ 'tablePrefix' => '',
2526 )
2627 );
2728 }
Index: trunk/extensions/MetricsReporting/MetricsReporting.php
@@ -19,7 +19,7 @@
2020 $wgMetricsDBname = '';
2121 $wgMetricsDBuser = '';
2222 $wgMetricsDBpassword = '';
23 -//$wgMetricsDBtype = 'mysql';
 23+$wgMetricsDBtype = 'mysql';
2424
2525 $dir = dirname( __FILE__ ) . '/';
2626
Index: trunk/extensions/MetricsReporting/ApiAnalytics.php
@@ -43,7 +43,7 @@
4444 public function getAllowedParams() {
4545 return array(
4646 'metric' => array(
47 - ApiBase::PARAM_ISMULTI => false,
 47+ ApiBase::PARAM_ISMULTI => true,
4848 ApiBase::PARAM_TYPE => $this->metricModuleNames,
4949 ApiBase::PARAM_REQUIRED => true,
5050 ),

Status & tagging log