r90914 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90913‎ | r90914 | r90915 >
Date:22:19, 27 June 2011
Author:krinkle
Status:deferred
Tags:
Comment:
StyleGuideDemo
Continue implementation of the style guide for forms:


(r90908, r90909, r90912)
Modified paths:
  • /trunk/extensions/StyleGuideDemo/SpecialStyleGuideDemo.php (modified) (history)
  • /trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/ext.styleguidedemo.css (modified) (history)
  • /trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/ext.styleguidedemo.js (modified) (history)
  • /trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeActive.png (added) (history)

Diff [purge]

Index: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeActive.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeActive.png
___________________________________________________________________
Added: svn:mime-type
11 + image/png
Index: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/ext.styleguidedemo.css
@@ -7,8 +7,7 @@
88
99 .mw-htmlform-form {
1010 padding: 10px;
11 - float: left;
12 - max-width: 70%;
 11+ width: 450px;
1312 }
1413
1514 .mw-htmlform-errors {
Index: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/ext.styleguidedemo.js
@@ -21,7 +21,7 @@
2222 var $realButton = $( button ),
2323 $styleButton = $( '<div>', {
2424 'class': 'mw-htmlform-button',
25 - text: 'Share Mood'//$realButton.val()
 25+ text: $realButton.val()
2626 })
2727 .insertAfter( $realButton.hide() )
2828 .wrap(
Index: trunk/extensions/StyleGuideDemo/SpecialStyleGuideDemo.php
@@ -17,7 +17,10 @@
1818 public function execute( $par ) {
1919 global $wgUser, $wgOut;
2020
 21+ // Loads styles when javascript is disabled as well
2122 $wgOut->addModuleStyles( 'ext.styleguidedemo.css' );
 23+
 24+ // Enhancements
2225 $wgOut->addModules( 'ext.styleguidedemo.js' );
2326
2427 $this->setHeaders();
@@ -28,7 +31,7 @@
2932 $formOne = array(
3033 'Username' => array(
3134 'label-message' => 'styleguidedemo-username',
32 - 'required' => 1,
 35+ 'required' => true,
3336 'type' => 'text',
3437 'help-message' => array( 'styleguidedemo-username-help', wfMsg( 'styleguidedemo-username-infopage' ) ),
3538 'hint-message' => 'styleguidedemo-username-hint',
@@ -36,12 +39,13 @@
3740 ),
3841 'Password' => array(
3942 'label-message' => 'styleguidedemo-password',
40 - 'required' => 1,
 43+ 'required' => true,
4144 'type' => 'password',
4245 'help-message' => array( 'styleguidedemo-password-help', wfMsg( 'styleguidedemo-password-infopage' ) ),
4346 ),
4447 'ConfirmPassword' => array(
4548 'label-message' => 'styleguidedemo-confirmpassword',
 49+ 'required' => true,
4650 'type' => 'password',
4751 'help-message' => 'styleguidedemo-confirmpassword-help',
4852 ),
@@ -55,6 +59,9 @@
5660 );
5761 $form = new HTMLStyleForm( $formOne );
5862 $form->setTitle( $wgOut->getTitle() );
 63+ $form->setSubmitID( 'wpCreateaccount' );
 64+ $form->setSubmitName( 'wpCreateaccount' );
 65+ $form->setSubmitText( wfMsg( 'createaccount' ) );
5966 $form->show();
6067
6168

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90908StyleGuideDemo...krinkle21:21, 27 June 2011
r90909images! FolUp r90908krinkle21:31, 27 June 2011
r90912StyleGuideDemo...krinkle21:56, 27 June 2011

Status & tagging log