r90817 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90816‎ | r90817 | r90818 >
Date:04:31, 26 June 2011
Author:kaldari
Status:reverted (Comments)
Tags:
Comment:
I think having the WikiLove tab on user pages is going to cause much confusion, I would rather limit it to user talk pages for the initial launch
Modified paths:
  • /trunk/extensions/WikiLove/WikiLove.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/WikiLove.hooks.php
@@ -54,8 +54,8 @@
5555 return true;
5656 }
5757
58 - $title = self::getUserTalkPage( $skin->getTitle() );
59 - if ( !is_null( $title ) ) {
 58+ $title = $skin->getTitle();
 59+ if ( $title->getNamespace() == 3 ) {
6060 $out->addModules( 'ext.wikiLove.icon' );
6161 $out->addModules( 'ext.wikiLove.init' );
6262 self::$recipient = $title->getText();
@@ -108,7 +108,8 @@
109109 return true;
110110 }
111111
112 - if ( !is_null( self::getUserTalkPage( $skin->getTitle() ) ) ) {
 112+ $title = $skin->getTitle();
 113+ if ( $title->getNamespace() == 3 ) {
113114 $views['wikilove'] = array(
114115 'text' => wfMsg( 'wikilove-tab-text' ),
115116 'href' => '#',

Follow-up revisions

RevisionCommit summaryAuthorDate
r90820reverting r90817 per discussion with jormkaldari05:02, 26 June 2011

Comments

#Comment by Bawolff (talk | contribs)   04:33, 26 June 2011

Its a matter of preference, but using the constant NS_USER_TALK instead of 3 might be more self-documenting.

Status & tagging log