r90820 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90819‎ | r90820 | r90821 >
Date:05:02, 26 June 2011
Author:kaldari
Status:ok
Tags:
Comment:
reverting r90817 per discussion with jorm
Modified paths:
  • /trunk/extensions/WikiLove/WikiLove.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/WikiLove.hooks.php
@@ -54,8 +54,8 @@
5555 return true;
5656 }
5757
58 - $title = $skin->getTitle();
59 - if ( $title->getNamespace() == 3 ) {
 58+ $title = self::getUserTalkPage( $skin->getTitle() );
 59+ if ( !is_null( $title ) ) {
6060 $out->addModules( 'ext.wikiLove.icon' );
6161 $out->addModules( 'ext.wikiLove.init' );
6262 self::$recipient = $title->getText();
@@ -108,8 +108,7 @@
109109 return true;
110110 }
111111
112 - $title = $skin->getTitle();
113 - if ( $title->getNamespace() == 3 ) {
 112+ if ( !is_null( self::getUserTalkPage( $skin->getTitle() ) ) ) {
114113 $views['wikilove'] = array(
115114 'text' => wfMsg( 'wikilove-tab-text' ),
116115 'href' => '#',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90817I think having the WikiLove tab on user pages is going to cause much confusio...kaldari04:31, 26 June 2011

Status & tagging log