r90767 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90766‎ | r90767 | r90768 >
Date:12:28, 25 June 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
Correct alignment for RevisionDelete button
Modified paths:
  • /trunk/phase3/includes/HistoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HistoryPage.php
——@@ -409,9 +409,8 @@
410410 }
411411
412412 private function getRevisionButton( $name, $msg ) {
413 - global $wgContLang;
414413 $this->preventClickjacking();
415 - $float = $wgContLang->alignEnd();
 414+ $float = wfUILang()->alignEnd();
416415 # Note bug #20966, <button> is non-standard in IE<8
417416 $element = Html::element( 'button',
418417 array(

Comments

#Comment by Brion VIBBER (talk | contribs)   23:13, 28 June 2011

You know, we really ought to be able to do most of these alignment thingies with CSS classes these days... We might want to look into that before changing all instances.

#Comment by SPQRobin (talk | contribs)   03:47, 6 July 2011

I added .mw-float-start & .mw-float-end in r91518.

Status & tagging log