r90766 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90765‎ | r90766 | r90767 >
Date:12:18, 25 June 2011
Author:hashar
Status:resolved (Comments)
Tags:
Comment:
Rename messages from r90670
* uses hyphens instead of underscore
* follow the tooltip-<message> format
* rephrase tooltip-invert per CR
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -642,12 +642,12 @@
643643 $invert = Xml::checkLabel(
644644 wfMsg( 'invert' ), 'invert', 'nsinvert',
645645 $opts['invert'],
646 - array( 'title' => wfMsg( 'invert_tip' ) )
 646+ array( 'title' => wfMsg( 'tooltip-invert' ) )
647647 );
648648 $associated = Xml::checkLabel(
649649 wfMsg( 'namespace_association' ), 'associated', 'nsassociated',
650650 $opts['associated'],
651 - array( 'title' => wfMsg( 'namespace_association_tip' ) )
 651+ array( 'title' => wfMsg( 'tooltip-namespace_association' ) )
652652 );
653653 return array( $nsLabel, "$nsSelect $invert $associated" );
654654 }
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -2605,9 +2605,9 @@
26062606 'invert' => 'Displayed in [[Special:RecentChanges|RecentChanges]], [[Special:RecentChangesLinked|RecentChangesLinked]] and [[Special:Watchlist|Watchlist]]
26072607
26082608 {{Identical|Invert selection}}',
2609 -'invert_tip' => 'Used in [[Special:Recentchanges]] as a tooltip for the invert checkbox. See also the \'invert\' message.',
 2609+'tooltip-invert' => 'Used in [[Special:Recentchanges]] as a tooltip for the invert checkbox. See also the \'invert\' message.',
26102610 'namespace_association' => 'Used in [[Special:Recentchanges]] with a checkbox which selects the associated namespace to be added to the selected namespace, so that both are searched (or excluded depending on another checkbox selection). The association is between a namespace and its talk namespace.',
2611 -'namespace_association_tip' => 'Used in [[Special:Recentchanges]] as a tooltip for the associated namespace checkbox. See also namespace_association message.',
 2611+'tooltip-namespace_association' => 'Used in [[Special:Recentchanges]] as a tooltip for the associated namespace checkbox. See also namespace_association message.',
26122612 'blanknamespace' => 'Name for main namespace (blank namespace) in drop-down menus at [[Special:RecentChanges]] and other special pages.',
26132613
26142614 # Contributions
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2963,9 +2963,9 @@
29642964 # Namespace form on various pages
29652965 'namespace' => 'Namespace:',
29662966 'invert' => 'Invert selection',
2967 -'invert_tip' => 'Check this box to also filter out the current namespace selection',
 2967+'tooltip-invert' => 'Check this box to hides changes in the selected namespace',
29682968 'namespace_association' => 'Associated namespace',
2969 -'namespace_association_tip' => 'Check this box to also include the talk or subject namespace associated to your selection',
 2969+'tooltip-namespace_association' => 'Check this box to also include the talk or subject namespace associated to your selection',
29702970 'blanknamespace' => '(Main)',
29712971
29722972 # Contributions

Follow-up revisions

RevisionCommit summaryAuthorDate
r90866Tweaked r90766 messages. Still awkward. Also, this still needs JS to disable ...aaron23:50, 26 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90670Add tooltips to the Special:Recentchanges checkboxes...hashar20:00, 23 June 2011

Comments

#Comment by Raymond (talk | contribs)   12:55, 25 June 2011

Please update messages.inc accordingly.

#Comment by Hashar (talk | contribs)   23:50, 25 June 2011

I need to add tests for messages.inc. I keep forgetting about it :(

Done in r90803

Status & tagging log