r90752 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90751‎ | r90752 | r90753 >
Date:03:59, 25 June 2011
Author:reedy
Status:deferred (Comments)
Tags:
Comment:
Fix last call to makeKnownLink
Modified paths:
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_EditPageAjax.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_EditPageAjax.php
——@@ -574,7 +574,7 @@
575575
576576
577577 if ( $this->mvd_id == 'seq' ) {
578 - $cancel = $sk->makeKnownLink( $this->mTitle->getPrefixedText(),
 578+ $cancel = $sk->makeKnownLinkObj( $this->mTitle,
579579 wfMsgExt( 'cancel', array( 'parseinline' ) ) );
580580 $edithelpurl = Skin::makeInternalOrExternalUrl( wfMsgForContent( 'mv_edithelpsequence' ) );
581581 } else {

Comments

#Comment by Jack Phoenix (talk | contribs)   18:43, 25 June 2011

Linker::makeKnownLinkObj() has been deprecated since 1.16 and the docs tell you to use Linker::link() instead; maybe Linker::linkKnown() would be appropriate here?

Status & tagging log