r90753 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90752‎ | r90753 | r90754 >
Date:04:11, 25 June 2011
Author:aaron
Status:ok
Tags:
Comment:
Follow-up r90749:
* Removed useless ufg_group index from user_former_groups
* Index name consistency
Modified paths:
  • /trunk/phase3/maintenance/archives/patch-user_former_groups.sql (modified) (history)
  • /trunk/phase3/maintenance/postgres/archives/patch-user_former_groups.sql (modified) (history)
  • /trunk/phase3/maintenance/postgres/tables.sql (modified) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tables.sql
@@ -173,7 +173,6 @@
174174 ) /*$wgDBTableOptions*/;
175175
176176 CREATE UNIQUE INDEX /*i*/ufg_user_group ON /*_*/user_former_groups (ufg_user,ufg_group);
177 -CREATE INDEX /*i*/ufg_group ON /*_*/user_former_groups (ufg_group);
178177
179178 --
180179 -- Stores notifications of user talk page changes, for the display
Index: trunk/phase3/maintenance/archives/patch-user_former_groups.sql
@@ -3,8 +3,7 @@
44 CREATE TABLE /*_*/user_former_groups (
55 -- Key to user_id
66 ufg_user int unsigned NOT NULL default 0,
7 - ufg_group varbinary(16) NOT NULL default '',
8 -
9 - PRIMARY KEY (ufg_user,ufg_group),
10 - KEY (ufg_group)
 7+ ufg_group varbinary(16) NOT NULL default ''
118 ) /*$wgDBTableOptions*/;
 9+
 10+CREATE UNIQUE INDEX /*i*/ufg_user_group ON /*_*/user_former_groups (ufg_user,ufg_group);
Index: trunk/phase3/maintenance/postgres/archives/patch-user_former_groups.sql
@@ -2,4 +2,4 @@
33 ufg_user INTEGER NULL REFERENCES mwuser(user_id) ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED,
44 ufg_group TEXT NOT NULL
55 );
6 -CREATE UNIQUE INDEX user_former_groups_unique ON user_former_groups (ufg_user, ufg_group);
 6+CREATE UNIQUE INDEX ufg_user_group ON user_former_groups (ufg_user, ufg_group);
Index: trunk/phase3/maintenance/postgres/tables.sql
@@ -58,7 +58,7 @@
5959 ufg_user INTEGER NULL REFERENCES mwuser(user_id) ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED,
6060 ufg_group TEXT NOT NULL
6161 );
62 -CREATE UNIQUE INDEX user_former_groups_unique ON user_former_groups (ufg_user, ufg_group);
 62+CREATE UNIQUE INDEX ufg_user_group ON user_former_groups (ufg_user, ufg_group);
6363
6464 CREATE TABLE user_newtalk (
6565 user_id INTEGER NOT NULL REFERENCES mwuser(user_id) ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90749Added one-time promote support via Autopromote::autopromoteOnceHook function....aaron02:52, 25 June 2011

Status & tagging log