r90658 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90657‎ | r90658 | r90659 >
Date:09:26, 23 June 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r85596, recursiveTagParse returns a string, not a parser output object
Modified paths:
  • /trunk/extensions/SubPageList3/SubPageList3.php (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -473,6 +473,8 @@
474474 *
475475 * @param $text String: text extension wants to have parsed
476476 * @param $frame PPFrame: The frame to use for expanding any template variables
 477+ *
 478+ * @return string
477479 */
478480 function recursiveTagParse( $text, $frame=false ) {
479481 wfProfileIn( __METHOD__ );
Index: trunk/extensions/SubPageList3/SubPageList3.php
@@ -504,7 +504,7 @@
505505 wfProfileIn( __METHOD__ );
506506 $output = $this->parser->recursiveTagParse( $text );
507507 wfProfileOut( __METHOD__ );
508 - return $output->getText();
 508+ return $output;
509509 }
510510
511511 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r90659MFT r90658reedy09:52, 23 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85596* (bug 13163) Activate SubPageList3 extension on English Wikiversity...reedy00:00, 7 April 2011

Status & tagging log