r85596 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85595‎ | r85596 | r85597 >
Date:00:00, 7 April 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
* (bug 13163) Activate SubPageList3 extension on English Wikiversity

Switch parse() to recursiveTagParse()
Modified paths:
  • /trunk/extensions/SubPageList3/SubPageList3.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SubPageList3/SubPageList3.php
@@ -502,8 +502,7 @@
503503 */
504504 function parse( $text ) {
505505 wfProfileIn( __METHOD__ );
506 - $options = $this->parser->mOptions;
507 - $output = $this->parser->parse( $text, $this->title, $options, true, false );
 506+ $output = $this->parser->recursiveTagParse( $text );
508507 wfProfileOut( __METHOD__ );
509508 return $output->getText();
510509 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r90651Copying SubPageList3 from trunk to 1.17wmf1 per bug 13163.tstarling06:58, 23 June 2011
r90658Followup r85596, recursiveTagParse returns a string, not a parser output objectreedy09:26, 23 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85590* (bug 13163) Activate SubPageList3 extension on English Wikiversity...reedy23:43, 6 April 2011

Comments

#Comment by Tim Starling (talk | contribs)   07:43, 23 June 2011

PHP fatal error in /home/wikipedia/common/php-1.17/extensions/SubPageList3/SubPageList3.php line 507: Call to a member function getText() on a non-object

Status & tagging log