r90613 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90612‎ | r90613 | r90614 >
Date:21:56, 22 June 2011
Author:brion
Status:reverted
Tags:
Comment:
Followup r90595: Tweak tablesorter tests so they run on r86088 version of jquery.tablesorter.js -- which actually passes these tests. The key regressions appear to have come in in r86337.
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
@@ -3,8 +3,8 @@
44 module( 'jquery.tablesorter.test.js' );
55
66 // setup hack
7 -mw.config.set('wgMonthNames', ['', 'January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December']);
8 -mw.config.set('wgMonthNamesShort', ['', 'Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']);
 7+mw.config.set('wgMonthNames', window.wgMonthNames = ['', 'January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December']);
 8+mw.config.set('wgMonthNamesShort', window.wgMonthNamesShort = ['', 'Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']);
99
1010 test( '-- Initial check', function() {
1111 expect(1);

Follow-up revisions

RevisionCommit summaryAuthorDate
r94393Reverting r90613 and the like, no need to set global variables (at least not ...krinkle22:59, 12 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86088Completely rewritten table sorting script....diebuche21:47, 14 April 2011
r86337r86088: Get rid of eval by implemting a MergeSort algorithm. It's a few ms sl...diebuche19:20, 18 April 2011
r90595Add initial QUnit JS test cases for jquery.tablesorter -- NOTE THERE ARE IN F...brion19:30, 22 June 2011

Status & tagging log