r94393 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94392‎ | r94393 | r94394 >
Date:22:59, 12 August 2011
Author:krinkle
Status:ok
Tags:
Comment:
Reverting r90613 and the like, no need to set global variables (at least not anymore).
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
@@ -3,9 +3,9 @@
44 module( 'jquery.tablesorter' );
55
66 // setup hack
7 -mw.config.set( 'wgMonthNames', window.wgMonthNames = ['', 'January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December']);
8 -mw.config.set( 'wgMonthNamesShort', window.wgMonthNamesShort = ['', 'Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']);
9 -mw.config.set( 'wgDefaultDateFormat', window.wgDefaultDateFormat = 'dmy' );
 7+mw.config.set( 'wgMonthNames', ['', 'January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December']);
 8+mw.config.set( 'wgMonthNamesShort', ['', 'Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']);
 9+mw.config.set( 'wgDefaultDateFormat', 'dmy' );
1010
1111 test( '-- Initial check', function() {
1212 expect(1);
@@ -181,7 +181,7 @@
182182 ],
183183 function( $table ) {
184184 // @fixme reset it at end or change module to allow us to override it
185 - mw.config.set( 'wgDefaultDateFormat', window.wgDefaultDateFormat = 'dmy' );
 185+ mw.config.set( 'wgDefaultDateFormat', 'dmy' );
186186 $table.tablesorter();
187187 $table.find( '.headerSort:eq(0)' ).click();
188188 }
@@ -207,7 +207,7 @@
208208 ],
209209 function( $table ) {
210210 // @fixme reset it at end or change module to allow us to override it
211 - mw.config.set( 'wgDefaultDateFormat', window.wgDefaultDateFormat = 'mdy' );
 211+ mw.config.set( 'wgDefaultDateFormat', 'mdy' );
212212 $table.tablesorter();
213213 $table.find( '.headerSort:eq(0)' ).click();
214214 }
@@ -346,7 +346,7 @@
347347 complexMDYDates,
348348 complexMDYSorted,
349349 function( $table ) {
350 - mw.config.set( 'wgDefaultDateFormat', window.wgDefaultDateFormat = 'mdy' );
 350+ mw.config.set( 'wgDefaultDateFormat', 'mdy' );
351351 $table.tablesorter();
352352 $table.find( '.headerSort:eq(0)' ).click();
353353 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90613Followup r90595: Tweak tablesorter tests so they run on r86088 version of jqu...brion21:56, 22 June 2011

Status & tagging log