r90549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90548‎ | r90549 | r90550 >
Date:21:14, 21 June 2011
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Followup r90020: use startid for consistency, and document endid
Modified paths:
  • /trunk/phase3/maintenance/storage/compressOld.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/storage/compressOld.php
@@ -17,7 +17,8 @@
1818 * -c <chunk-size> maximum number of revisions in a concat chunk
1919 * -b <begin-date> earliest date to check for uncompressed revisions
2020 * -e <end-date> latest revision date to compress
21 - * -s <start-id> the old_id to start from
 21+ * -s <startid> the old_id to start from
 22+ * -n <endid> the old_id to stop at
2223 * --extdb <cluster> store specified revisions in an external cluster (untested)
2324 *
2425 * This program is free software; you can redistribute it and/or modify
@@ -55,7 +56,7 @@
5657 $this->addOption( 'chunksize', 'Maximum number of revisions in a concat chunk', false, true, 'c' );
5758 $this->addOption( 'begin-date', 'Earliest date to check for uncompressed revisions', false, true, 'b' );
5859 $this->addOption( 'end-date', 'Latest revision date to compress', false, true, 'e' );
59 - $this->addOption( 'start-id', 'The old_id to start from', false, true, 's');
 60+ $this->addOption( 'startid', 'The old_id to start from', false, true, 's' );
6061 $this->addOption( 'extdb', 'Store specified revisions in an external cluster (untested)', false, true );
6162 $this->addOption( 'endid', 'Stop at this old_id', false, true, 'n' );
6263 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r112793Bug 34734 - compressOld.php ignoring -s option...hashar11:33, 1 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90020Rewrite compressOld to subclass maintenanance...demon23:28, 13 June 2011

Comments

#Comment by Hashar (talk | contribs)   11:33, 1 March 2012

Caused Bug 34734 - compressOld.php ignoring -s option

Status & tagging log