r90548 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90547‎ | r90548 | r90549 >
Date:21:07, 21 June 2011
Author:daniel
Status:reverted (Comments)
Tags:
Comment:
direct message rendering, handling anon users
Modified paths:
  • /branches/REL1_17/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/ChangesList.php
——@@ -433,7 +433,7 @@
434434 $page = $rc->getTitle();
435435 /** Check for rollback and edit permissions, disallow special pages, and only
436436 * show a link on the top-most revision */
437 - if ($wgUser->isAllowed('rollback') && $rc->mAttribs['page_latest'] == $rc->mAttribs['rc_this_oldid'] )
 437+ if ($wgUser->isAllowed('rollback') && !empty($rc->mAttribs['page_latest']) && $rc->mAttribs['page_latest'] == $rc->mAttribs['rc_this_oldid'] )
438438 {
439439 $rev = new Revision( array(
440440 'id' => $rc->mAttribs['rc_this_oldid'],

Follow-up revisions

RevisionCommit summaryAuthorDate
r90563Revert r90548, accidental commit, apparently not fully tested.tstarling00:16, 22 June 2011

Comments

#Comment by 😂 (talk | contribs)   21:17, 21 June 2011

Is there a bug for this? Is this a MFT? More clues would be nice :)

#Comment by Daniel Kinzler (WMDE) (talk | contribs)   22:01, 21 June 2011

err... i didn't mean to commit this, i typed svn ci in the wrong dir :)

so the commit message is completely unrelated. this *does* seem to fix a bug, though. i got "unknown index" for page_latest when creating pages.

not sure though if it always happens. i wasn't really debugging core, i was working on an extension and accidentally committed a hot fix from by install.

Status & tagging log