r90349 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90348‎ | r90349 | r90350 >
Date:17:27, 18 June 2011
Author:btongminh
Status:reverted
Tags:
Comment:
Follow-up r90340: just add the test file to SVN, which hopefully fixes the cruisecontrol problems.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/upload/UploadStashTest.php (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/upload/bug29408 (added) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/upload/bug29408
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/tests/phpunit/includes/upload/bug29408
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/phase3/tests/phpunit/includes/upload/UploadStashTest.php
@@ -11,7 +11,7 @@
1212
1313 // Setup a file for bug 29408
1414 $this->bug29408File = dirname( __FILE__ ) . '/bug29408';
15 - file_put_contents( $this->bug29408File, "\x00" );
 15+ // file_put_contents( $this->bug29408File, "\x00" );
1616 }
1717
1818 public function testBug29408() {
@@ -28,8 +28,5 @@
2929
3030 public function tearDown() {
3131 parent::tearDown();
32 -
33 - unlink( $this->bug29408File );
34 -
3532 }
3633 }
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r90530Revert r90483, if tesla has problems, it should get proper permissions to the...platonides15:06, 21 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90340(bug 29408) Key 'something.' is not in a proper format...btongminh14:56, 18 June 2011

Status & tagging log