r89741 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89740‎ | r89741 | r89742 >
Date:20:19, 8 June 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
1.17: MFT r84739, r89707
Modified paths:
  • /branches/REL1_17/phase3/includes/MagicWord.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/installer/Installer.php
@@ -1212,7 +1212,6 @@
12131213 global $IP;
12141214 $exts = $this->getVar( '_Extensions' );
12151215 $IP = $this->getVar( 'IP' );
1216 - $path = $IP . '/extensions';
12171216
12181217 /**
12191218 * We need to include DefaultSettings before including extensions to avoid
@@ -1226,7 +1225,7 @@
12271226 require( "$IP/includes/DefaultSettings.php" );
12281227
12291228 foreach( $exts as $e ) {
1230 - require_once( "$path/$e/$e.php" );
 1229+ require_once( $IP . '/extensions' . "/$e/$e.php" );
12311230 }
12321231
12331232 $hooksWeWant = isset( $wgHooks['LoadExtensionSchemaUpdates'] ) ?
Property changes on: branches/REL1_17/phase3/includes/installer/Installer.php
___________________________________________________________________
Modified: svn:mergeinfo
12341233 Merged /trunk/phase3/includes/installer/Installer.php:r84739,89707
Index: branches/REL1_17/phase3/includes/MagicWord.php
@@ -178,7 +178,7 @@
179179
180180 /**#@-*/
181181
182 - function __construct($id = 0, $syn = '', $cs = false) {
 182+ function __construct($id = 0, $syn = array(), $cs = false) {
183183 $this->mId = $id;
184184 $this->mSynonyms = (array)$syn;
185185 $this->mCaseSensitive = $cs;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84739Changes default value so that it's not converted to array( 0 => '' ) by the (...ialex11:07, 25 March 2011
r89707quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e ...wikinaut22:30, 7 June 2011

Comments

#Comment by Tim Starling (talk | contribs)   23:45, 8 June 2011

Why are you not writing release notes?

#Comment by Catrope (talk | contribs)   08:19, 9 June 2011

Grah, I'm sorry about that. The release notes don't come along with a normal merge because the file names differ (and the contents likely do as well), and I forgot to add them manually.

Status & tagging log