r89707 MediaWiki - Code Review archive

remaining problem: $e . If an extensions take the liberty to use $e , it changes the loop.

Please fix finally.

s/take/takes/ (my keyboard does not like me)

Attention, we need a better code for the loop to avoid $e. Any volunteers?

This is prefectly sane. On the next iteration foreach() sets $e again, so the changed $e would not corrupt it.

A change to $ext looks more suspicious, but it is locked by the foreach, so no problem there, either.

<?php

$a = array( 1, 2, 3 );

foreach( $a as $b ) {
	echo "$b\n";
	$a = array( 'foo', 'bar', 'baz' );
	$b = 'Hello World!';
}

outputs

1
2
3

(and leaves $a set to 'foo', 'bar', 'baz')

Foreach runs on a copy of the array, so changing or overwriting $ext has no effect on the loop. This fix looks sufficient to me. Tagging 1.17, 1.18

Oops, I overlooked that, yes, thanks, will try to remember this.

+++ I am happy that the issue of "installation plus extensions" appears now finally be solved +++

I could rename it to $pleaseDontNameYourVariableThis ;-)