r89727 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89726‎ | r89727 | r89728 >
Date:12:09, 8 June 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17: Back out r87711 per CR on r89676
Modified paths:
  • /branches/REL1_17/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)
  • /branches/REL1_17/phase3/includes/resourceloader/ResourceLoaderContext.php (modified) (history)
  • /branches/REL1_17/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/resourceloader/ResourceLoader.php
@@ -703,8 +703,7 @@
704704 * Convert an array of module names to a packed query string.
705705 *
706706 * For example, array( 'foo.bar', 'foo.baz', 'bar.baz', 'bar.quux' )
707 - * becomes 'foo!bar,baz|bar!baz,quux'
708 - * The ! is for IE6 being stupid with extensions.
 707+ * becomes 'foo.bar,baz|bar.baz,quux'
709708 * @param $modules array of module names (strings)
710709 * @return string Packed query string
711710 */
@@ -722,8 +721,7 @@
723722 $p = $prefix === '' ? '' : $prefix . '.';
724723 $arr[] = $p . implode( ',', $suffixes );
725724 }
726 - $str = implode( '|', $arr );
727 - return str_replace( ".", "!", $str ); # bug 28840
 725+ return implode( '|', $arr );
728726 }
729727
730728 /**
Property changes on: branches/REL1_17/phase3/includes/resourceloader/ResourceLoader.php
___________________________________________________________________
Modified: svn:mergeinfo
731729 Reverse-merged /trunk/phase3/includes/resourceloader/ResourceLoader.php:r87711
Index: branches/REL1_17/phase3/includes/resourceloader/ResourceLoaderContext.php
@@ -67,13 +67,12 @@
6868 /**
6969 * Expand a string of the form jquery.foo,bar|jquery.ui.baz,quux to
7070 * an array of module names like array( 'jquery.foo', 'jquery.bar',
71 - * 'jquery.ui.baz', 'jquery.ui.quux' ) Also translating ! to .
 71+ * 'jquery.ui.baz', 'jquery.ui.quux' )
7272 * @param $modules String Packed module name list
7373 * @return array of module names
7474 */
7575 public static function expandModuleNames( $modules ) {
7676 $retval = array();
77 - $modules = str_replace( "!", ".", $modules ); # bug 28840 - IE is stupid.
7877 $exploded = explode( '|', $modules );
7978 foreach ( $exploded as $group ) {
8079 if ( strpos( $group, ',' ) === false ) {
Index: branches/REL1_17/phase3/resources/mediawiki/mediawiki.js
@@ -686,7 +686,7 @@
687687 var p = prefix === '' ? '' : prefix + '.';
688688 arr.push( p + moduleMap[prefix].join( ',' ) );
689689 }
690 - return arr.join( '|' ).replace( /\./g, '!' );
 690+ return arr.join( '|' );
691691 }
692692
693693
Property changes on: branches/REL1_17/phase3/resources/mediawiki/mediawiki.js
___________________________________________________________________
Modified: svn:mergeinfo
694694 Reverse-merged /trunk/phase3/resources/mediawiki/mediawiki.js:r87711

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87711(bug 28840) Commit patch by bawolff that encodes dots in ResourceLoader modul...catrope13:10, 9 May 2011
r896761.17: MFT r82247, r87203, r87265, r87494, r87497, r87711, r87840, r88076, r89615catrope19:09, 7 June 2011

Status & tagging log