r87265 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87264‎ | r87265 | r87266 >
Date:17:57, 2 May 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix r87203: don't use a for..in loop on an array
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -949,7 +949,7 @@
950950 // No splitting needed
951951 reqs = [ groups[group] ];
952952 }
953 - for ( var r in reqs ) {
 953+ for ( var r = 0; r < reqs.length; r++ ) {
954954 requests[requests.length] = $.extend(
955955 { 'modules': reqs[r].join( '|' ) }, reqBase
956956 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r896761.17: MFT r82247, r87203, r87265, r87494, r87497, r87711, r87840, r88076, r89615catrope19:09, 7 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87203(bug 28738) Implement request splitting in mw.loader so ResourceLoader reques...catrope18:41, 1 May 2011

Status & tagging log