r89605 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89604‎ | r89605 | r89606 >
Date:20:57, 6 June 2011
Author:krinkle
Status:resolved (Comments)
Tags:
Comment:
Fix bug that brakes the 'jquery.tabIndex > firstTabIndex' test in IE6/IE7 (Thanks TestSwarm).
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.tabIndex.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.tabIndex.js
@@ -13,7 +13,10 @@
1414 var tabIndex = parseInt( $(this).attr( 'tabindex' ), 10 );
1515 if ( i === 0 ) {
1616 minTabIndex = tabIndex;
17 - } else if ( tabIndex < minTabIndex ) {
 17+ // In IE6/IE7 the above jQuery selector returns all elements,
 18+ // becuase it has a default value for tabIndex in IE6/IE7 of 0
 19+ // (rather than null/undefined). Therefore check "> 0" as well
 20+ } else if ( tabIndex > 0 && tabIndex < minTabIndex ) {
1821 minTabIndex = tabIndex;
1922 }
2023 } );

Follow-up revisions

RevisionCommit summaryAuthorDate
r89613Redo r89605 in a better way.krinkle21:43, 6 June 2011
r89614Alright, IE7 is fixed by r89613. IE6 stays problematic, for some reason it co...krinkle21:51, 6 June 2011

Comments

#Comment by Krinkle (talk | contribs)   19:58, 15 July 2011

Before Roan tells me, I know it was supposed to be "breaks" and not "brakes" Face-grin.svg

Status & tagging log