r89614 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89613‎ | r89614 | r89615 >
Date:21:51, 6 June 2011
Author:krinkle
Status:ok
Tags:
Comment:
Alright, IE7 is fixed by r89613. IE6 stays problematic, for some reason it contains non-nodes as well (presumably whitespace/textnodes). This oughta fix it forever (poke r89605)
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.tabIndex.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.tabIndex.js
@@ -15,7 +15,7 @@
1616 // becuase it has a default value for tabIndex in IE6/IE7 of 0
1717 // (rather than null/undefined). Therefore check "> 0" as well
1818 if ( tabIndex > 0 ) {
19 - if ( i === 0 ) {
 19+ if ( minTabIndex === null ) {
2020 minTabIndex = tabIndex;
2121 } else if ( tabIndex < minTabIndex ) {
2222 minTabIndex = tabIndex;
@@ -34,7 +34,7 @@
3535 var maxTabIndex = null;
3636 $(this).find( '[tabindex]' ).each( function( i ) {
3737 var tabIndex = parseInt( $(this).attr( 'tabindex' ), 10 );
38 - if ( i === 0 ) {
 38+ if ( maxTabIndex === null ) {
3939 maxTabIndex = tabIndex;
4040 } else if ( tabIndex > maxTabIndex ) {
4141 maxTabIndex = tabIndex;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89605Fix bug that brakes the 'jquery.tabIndex > firstTabIndex' test in IE6/IE7 (Th...krinkle20:57, 6 June 2011
r89613Redo r89605 in a better way.krinkle21:43, 6 June 2011

Status & tagging log