r89281 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89280‎ | r89281 | r89282 >
Date:19:09, 1 June 2011
Author:awjrichards
Status:reverted (Comments)
Tags:
Comment:
Follow up r89277, fixing a change that should've been local to me only
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/ArticleFeedback.php
——@@ -11,7 +11,7 @@
1212 */
1313
1414 /* XXX: Survey setup */
15 -require_once( $IP . '/extensions/SimpleSurvey/SimpleSurvey.php' );
 15+require_once( dirname( dirname( __FILE__ ) ) . '/extensions/SimpleSurvey/SimpleSurvey.php' );
1616
1717 /* Configuration */
1818

Follow-up revisions

RevisionCommit summaryAuthorDate
r89366Reverting r89281, and and part of r89277, restoring the path to SimpleSurvey ...tparscal21:10, 2 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89277Added 'problem articles' view to dashboard; refactored dashboard code (popula...awjrichards18:32, 1 June 2011

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   21:09, 2 June 2011

This probably doesn't do what you think it does. the dirname of __FILE__ is extensions/ArticleFeeback, and the dirname of extensions/ArticleFeedback is extensions - appending /extensions/... to that doesn't work out very well unless you have a really strange checkout.

#Comment by Awjrichards (talk | contribs)   21:13, 2 June 2011

Oh - my bad, I was trying to reset it to what's in r88771 (which is the same thing sans 'extensionss')

Status & tagging log