r89227 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89226‎ | r89227 | r89228 >
Date:20:35, 31 May 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
really add NewParserTest to the Stub group

PHPUnit 5.3.13 does not like having comments after the '@group name' command.
This class was not part of the Stub group and run despite the exclusion of
the Stub group in our suite.xml

Properly fix issue described in r89223 and complete r89226
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php
——@@ -1,9 +1,11 @@
22 <?php
33
44 /**
 5+ * Although marked as a stub, can work independently.
 6+ *
57 * @group Database
68 * @group Parser
7 - * @group Stub (can also work independently)
 9+ * @group Stub
810 */
911 class NewParserTest extends MediaWikiTestCase {
1012

Follow-up revisions

RevisionCommit summaryAuthorDate
r92350MFT to REL1_18...hashar10:27, 16 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89223NewParserTest.php can now work independently...hashar19:51, 31 May 2011
r89226Revert r89223. MediaWikiParserTest is needed to run all the $wgParserTestFiles...platonides20:30, 31 May 2011

Comments

#Comment by Hashar (talk | contribs)   20:36, 31 May 2011

Per discussion on IRC with Platonides

#Comment by Platonides (talk | contribs)   20:37, 31 May 2011

Silly PHPUnit 5.3.13

#Comment by Hashar (talk | contribs)   20:45, 31 May 2011

Confirmed to work for build 2011-05-31T20:41:02 : 


failure  ParserTests::testParserTest::testParserTest with data set #287()

We now only run core parser tests once! Good job :)

Status & tagging log