r92350 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92349‎ | r92350 | r92351 >
Date:10:27, 16 July 2011
Author:hashar
Status:deferred
Tags:
Comment:
MFT to REL1_18
r89227 : fix up CC running parser tests twice!
r89668 : Fix (Api)BlockTest for Sqlite
-> locally fix error on ApiBlockTest::testMakeNormalBlock
r90860 : block, compare infinity with mExpiry not mTimestamp
Modified paths:
  • /branches/REL1_18/phase3/includes/Block.php (modified) (history)
  • /branches/REL1_18/phase3/tests/phpunit/includes/parser/NewParserTest.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/tests/phpunit/includes/parser/NewParserTest.php
@@ -1,9 +1,11 @@
22 <?php
33
44 /**
 5+ * Although marked as a stub, can work independently.
 6+ *
57 * @group Database
68 * @group Parser
7 - * @group Stub (can also work independently)
 9+ * @group Stub
810 */
911 class NewParserTest extends MediaWikiTestCase {
1012
Property changes on: branches/REL1_18/phase3/tests/phpunit/includes/parser/NewParserTest.php
___________________________________________________________________
Added: svn:mergeinfo
1113 Merged /branches/new-installer/phase3/tests/phpunit/includes/parser/NewParserTest.php:r43664-66004
1214 Merged /branches/REL1_15/phase3/tests/phpunit/includes/parser/NewParserTest.php:r51646
1315 Merged /branches/REL1_17/phase3/tests/phpunit/includes/parser/NewParserTest.php:r81445,81448
1416 Merged /branches/sqlite/tests/phpunit/includes/parser/NewParserTest.php:r58211-58321
1517 Merged /trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php:r87627-87628,87630,87632,87636,87640,87644,87998,88134,88231-88232,88250,88513,88769,89099,89108,89227,89301,89479-89480,90602,90612,90618,90626,90630-90631,90637,90655,90657,90666,90812
Index: branches/REL1_18/phase3/includes/Block.php
@@ -614,7 +614,7 @@
615615 $autoblock->prevents( 'editownusertalk', $this->prevents( 'editownusertalk' ) );
616616
617617 $dbr = wfGetDB( DB_READ );
618 - if ( $this->mTimestamp == $dbr->getInfinity() ) {
 618+ if ( $this->mExpiry == $dbr->getInfinity() ) {
619619 # Original block was indefinite, start an autoblock now
620620 $autoblock->mExpiry = Block::getAutoblockExpiry( wfTimestampNow() );
621621 } else {
@@ -701,7 +701,7 @@
702702 public function getRangeStart() {
703703 switch( $this->type ) {
704704 case self::TYPE_USER:
705 - return null;
 705+ return '';
706706 case self::TYPE_IP:
707707 return IP::toHex( $this->target );
708708 case self::TYPE_RANGE:
@@ -718,7 +718,7 @@
719719 public function getRangeEnd() {
720720 switch( $this->type ) {
721721 case self::TYPE_USER:
722 - return null;
 722+ return '';
723723 case self::TYPE_IP:
724724 return IP::toHex( $this->target );
725725 case self::TYPE_RANGE:
Property changes on: branches/REL1_18/phase3/includes/Block.php
___________________________________________________________________
Added: svn:mergeinfo
726726 Merged /branches/new-installer/phase3/includes/Block.php:r43664-66004
727727 Merged /branches/wmf-deployment/includes/Block.php:r53381
728728 Merged /branches/REL1_15/phase3/includes/Block.php:r51646
729729 Merged /branches/sqlite/includes/Block.php:r58211-58321
730730 Merged /trunk/phase3/includes/Block.php:r87586,87627-87628,87630,87840,87998,88085,88118,88124,88134,88231-88232,88250,88492,88498,88513,89099,89108,89668,90602,90612,90618,90626,90630-90631,90637,90655,90657,90666,90812,90860

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89227really add NewParserTest to the Stub group...hashar20:35, 31 May 2011
r89668Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning n...demon18:13, 7 June 2011
r90860Follow-up r84588 CRhappy-melon23:10, 26 June 2011

Status & tagging log