r89219 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89218‎ | r89219 | r89220 >
Date:17:19, 31 May 2011
Author:jeroendedauw
Status:ok (Comments)
Tags:
Comment:
this method should not be private? the parser function docs use it as public
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -793,8 +793,6 @@
794794 * Add an item to the strip state
795795 * Returns the unique tag which must be inserted into the stripped text
796796 * The tag will be replaced with the original text in unstrip()
797 - *
798 - * @private
799797 */
800798 function insertStripItem( $text ) {
801799 $rnd = "{$this->mUniqPrefix}-item-{$this->mMarkerIndex}-" . self::MARKER_SUFFIX;

Comments

#Comment by Reedy (talk | contribs)   19:58, 31 May 2011

We have too many of retarded comments like this

#Comment by Krinkle (talk | contribs)   20:00, 31 May 2011

Comments don't run!

#Comment by Platonides (talk | contribs)   21:53, 31 May 2011

It's to be used from inside the parsing process... which usually leads you to different files/classes.

Status & tagging log