r89218 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89217‎ | r89218 | r89219 >
Date:17:18, 31 May 2011
Author:hashar
Status:reverted
Tags:
Comment:
Profiler can be constructed without param

Before that patch, we could see warnings such as:
Missing argument 1 for Profiler::__construct(),
Modified paths:
  • /trunk/phase3/includes/profiler/Profiler.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/profiler/Profiler.php
@@ -42,7 +42,7 @@
4343 protected $mProfileID = false;
4444 private static $__instance = null;
4545
46 - function __construct( $params ) {
 46+ function __construct( $params = null ) {
4747 // Push an entry for the pre-profile setup time onto the stack
4848 global $wgRequestTime;
4949 if ( !empty( $wgRequestTime ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r89241Fix for r89206, r89218: always supply constructor parameterststarling23:50, 31 May 2011

Status & tagging log