r89204 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89203‎ | r89204 | r89205 >
Date:05:50, 31 May 2011
Author:tstarling
Status:ok (Comments)
Tags:
Comment:
* Fix hphpi mode in run-server, it wasn't quite working properly
Modified paths:
  • /trunk/phase3/includes/actions/PurgeAction.php (modified) (history)
  • /trunk/phase3/maintenance/hiphop/run-server (modified) (history)
  • /trunk/phase3/maintenance/hiphop/server.conf (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/hiphop/run-server
@@ -41,6 +41,7 @@
4242 '-c', "$thisDir/server.conf",
4343 '-v', "Server.SourceRoot=$sourceBase",
4444 '-v', "Server.IncludeSearchPaths.0=$sourceBase",
 45+ '-v', 'ServerVariables.MW_COMPILED=1',
4546 '--mode=server',
4647 '--port=8080'
4748 ),
@@ -55,6 +56,8 @@
5657 $sourceBase = realpath( "$IP/.." );
5758
5859 passthru(
 60+ 'cd ' . wfEscapeShellArg( $sourceBase ) . " && " .
 61+ 'MW_INSTALL_PATH=' . wfEscapeShellArg( $IP ) . ' ' .
5962 wfEscapeShellArg(
6063 'hphpi',
6164 '-c', "$thisDir/server.conf",
Index: trunk/phase3/maintenance/hiphop/server.conf
@@ -15,9 +15,6 @@
1616 EnableStaticContentFromDisk = false
1717 AlwaysUseRelativePath = true
1818 }
19 -ServerVariables {
20 - MW_COMPILED = 1
21 -}
2219 VirtualHost {
2320 * {
2421 ServerName = localhost
@@ -26,8 +23,8 @@
2724 * {
2825 pattern = ^/wiki/(.*)$
2926 to = /phase3/index.php?title=$1
 27+ qsa = true
3028 }
3129 }
3230 }
3331 }
34 -
Index: trunk/phase3/includes/actions/PurgeAction.php
@@ -57,7 +57,7 @@
5858 }
5959
6060 /**
61 - * purge is slightly wierd because it can be either formed or formless depending
 61+ * purge is slightly weird because it can be either formed or formless depending
6262 * on user permissions
6363 */
6464 public function show() {

Comments

#Comment by Tim Starling (talk | contribs)   05:52, 31 May 2011

Commit message was truncated. Also:

  • In the HipHop rewrite rule, allow query string append
  • Fixed a typo in a comment in PurgeAction.php

Status & tagging log