r89203 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89202‎ | r89203 | r89204 >
Date:04:36, 31 May 2011
Author:yaron
Status:deferred
Tags:
Comment:
Fixes for bugs in r89200
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_Utils.php
@@ -99,12 +99,12 @@
100100 $values = array();
101101 foreach ( $res as $value ) {
102102 if ( method_exists( $value, 'getTitle' ) ) {
103 - $title = $value->getTitle();
104 - if ( !is_null( $title ) ) {
105 - $values[] = $title->getText();
 103+ $valueTitle = $value->getTitle();
 104+ if ( !is_null( $valueTitle ) ) {
 105+ $values[] = $valueTitle->getText();
106106 }
107107 } else {
108 - $values[] = str_replace( '_' , ' ', $title->getWikiValue() );
 108+ $values[] = str_replace( '_' , ' ', $value->getWikiValue() );
109109 }
110110 }
111111 return array_unique( $values );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89200* Modified getSMWPropertyValues() to try to return an array of actual values,...yaron04:21, 31 May 2011