r89134 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89133‎ | r89134 | r89135 >
Date:20:33, 29 May 2011
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Add back space between size and comment in history pages (fix for r86764)
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
——@@ -1377,7 +1377,7 @@
13781378 if ( $rev->isDeleted( Revision::DELETED_COMMENT ) && $isPublic ) {
13791379 $block = " <span class=\"comment\">" . wfMsgHtml( 'rev-deleted-comment' ) . "</span>";
13801380 } else if ( $rev->userCan( Revision::DELETED_COMMENT ) ) {
1381 - $block = self::commentBlock( $rev->getComment( Revision::FOR_THIS_USER ),
 1381+ $block = ' ' . self::commentBlock( $rev->getComment( Revision::FOR_THIS_USER ),
13821382 $rev->getTitle(), $local );
13831383 } else {
13841384 $block = " <span class=\"comment\">" . wfMsgHtml( 'rev-deleted-comment' ) . "</span>";

Follow-up revisions

RevisionCommit summaryAuthorDate
r90101Revert r86764, r89134, r86827 -- added a second opaque boolean parameter to L...brion23:50, 14 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86764Embrace comment with () only when really needed. In Special:ListFiles and Ima...raymond13:23, 23 April 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   23:37, 14 June 2011

Probably needs revert along with r86764.

#Comment by Brion VIBBER (talk | contribs)   23:51, 14 June 2011

Reverted in r90101 along with its parent.

Status & tagging log