r86827 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86826‎ | r86827 | r86828 >
Date:17:58, 24 April 2011
Author:raymond
Status:reverted (Comments)
Tags:
Comment:
Followup r86764: don't parse the comment. Spotted by SPQRobin@Translatewiki and fixed the help of Ialex
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1304,7 +1304,7 @@
13051305 } else {
13061306 $formatted = self::formatComment( $comment, $title, $local );
13071307 if ( $embraced ) {
1308 - $formatted = wfMessage( 'parentheses', $formatted );
 1308+ $formatted = wfMessage( 'parentheses' )->rawParams( $formatted )->escaped();
13091309 }
13101310 return Html::rawElement( 'span', array( 'class' => 'comment' ), $formatted );
13111311 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r90101Revert r86764, r89134, r86827 -- added a second opaque boolean parameter to L...brion23:50, 14 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86764Embrace comment with () only when really needed. In Special:ListFiles and Ima...raymond13:23, 23 April 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   23:38, 14 June 2011

Probably needs revert along with r86764.

#Comment by Brion VIBBER (talk | contribs)   23:51, 14 June 2011

Reverted in r90101 along with its parent.

Status & tagging log