r88955 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88954‎ | r88955 | r88956 >
Date:23:47, 26 May 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
update method signatures
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QueryPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QueryPrinter.php
@@ -25,6 +25,12 @@
2626 */
2727 abstract class SMWResultPrinter {
2828
 29+ /**
 30+ * List of parameters, set by readParameters (which is deprecated)
 31+ * and can be used to store parameters in readParameters.
 32+ *
 33+ * @var array
 34+ */
2935 protected $m_params;
3036
3137 /**
@@ -96,7 +102,7 @@
97103 * Return serialised results in specified format.
98104 * Implemented by subclasses.
99105 */
100 - abstract protected function getResultText( /* SMWQueryResult */ $res, $outputmode );
 106+ abstract protected function getResultText( SMWQueryResult $res, $outputmode );
101107
102108 /**
103109 * Constructor. The parameter $format is a format string
@@ -112,7 +118,7 @@
113119 $this->mInline = $inline;
114120 $this->mLinkFirst = ( $smwgQDefaultLinking != 'none' );
115121 $this->mLinkOthers = ( $smwgQDefaultLinking == 'all' );
116 - $this->mLinker = class_exists('DummyLinker') ? new DummyLinker : new Linker; ///TODO: how can we get the default or user skin here (depending on context)?
 122+ $this->mLinker = class_exists( 'DummyLinker' ) ? new DummyLinker : new Linker; ///TODO: how can we get the default or user skin here (depending on context)?
117123 $this->useValidator = $useValidator;
118124 }
119125

Follow-up revisions

RevisionCommit summaryAuthorDate
r88958Follow-up to r88955 - all query printers' getResultText() signatures need to ...yaron03:42, 27 May 2011

Status & tagging log