r88954 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88953‎ | r88954 | r88955 >
Date:23:47, 26 May 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
update method signatures
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_KMLPrinter.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php
@@ -168,9 +168,9 @@
169169 * @param SMWQueryResult $res
170170 * @param $outputmode
171171 *
172 - * @return array
 172+ * @return array or string
173173 */
174 - public final function getResultText( /* SMWQueryResult */ $res, $outputmode ) {
 174+ public final function getResultText( SMWQueryResult $res, $outputmode ) {
175175 if ( $this->fatalErrorMsg === false ) {
176176 global $wgParser;
177177
@@ -325,7 +325,7 @@
326326 *
327327 * @return array
328328 */
329 - public final function getResult( /* SMWQueryResult */ $results, /* array */ $params, $outputmode ) {
 329+ public final function getResult( SMWQueryResult $results, array $params, $outputmode ) {
330330 // Skip checks, results with 0 entries are normal.
331331 $this->readParameters( $params, $outputmode );
332332
Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_KMLPrinter.php
@@ -33,7 +33,7 @@
3434 *
3535 * @return array
3636 */
37 - public function getResultText( /* SMWQueryResult */ $res, $outputmode ) {
 37+ public function getResultText( SMWQueryResult $res, $outputmode ) {
3838 if ( $outputmode == SMW_OUTPUT_FILE ) {
3939 return $this->getKML( $res, $outputmode );
4040 }

Status & tagging log