r88953 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r88952‎ \| r88953 \| r88954 >
Date:	23:47, 26 May 2011
Author:	jeroendedauw
Status:	deferred
Tags:
Comment:	update method signatures
Modified paths:	/trunk/extensions/SemanticResultFormats/Array/SRF_Array.php (modified) (history) /trunk/extensions/SemanticResultFormats/BibTeX/SRF_BibTeX.php (modified) (history) /trunk/extensions/SemanticResultFormats/Calendar/SRF_Calendar.php (modified) (history) /trunk/extensions/SemanticResultFormats/Exhibit/SRF_Exhibit.php (modified) (history) /trunk/extensions/SemanticResultFormats/Gallery/SRF_Gallery.php (modified) (history) /trunk/extensions/SemanticResultFormats/GoogleCharts/SRF_GoogleBar.php (modified) (history) /trunk/extensions/SemanticResultFormats/GoogleCharts/SRF_GooglePie.php (modified) (history) /trunk/extensions/SemanticResultFormats/GraphViz/SRF_Graph.php (modified) (history) /trunk/extensions/SemanticResultFormats/GraphViz/SRF_Process.php (modified) (history) /trunk/extensions/SemanticResultFormats/Math/SRF_Math.php (modified) (history) /trunk/extensions/SemanticResultFormats/Outline/SRF_Outline.php (modified) (history) /trunk/extensions/SemanticResultFormats/Ploticus/SRF_Ploticus.php (modified) (history) /trunk/extensions/SemanticResultFormats/TagCloud/SRF_TagCloud.php (modified) (history) /trunk/extensions/SemanticResultFormats/Timeline/SRF_Timeline.php (modified) (history) /trunk/extensions/SemanticResultFormats/iCalendar/SRF_iCalendar.php (modified) (history) /trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotBar.php (modified) (history) /trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotPie.php (modified) (history) /trunk/extensions/SemanticResultFormats/vCard/SRF_vCard.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/Outline/SRF_Outline.php
—	—	@@ -178,7 +178,7 @@
179	179	return $text;
180	180	}
181	181
182		~~- protected function getResultText( $res, $outputmode ) {~~
	182	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
183	183	$print_fields = array();
184	184	foreach ( $res->getPrintRequests() as $pr ) {
185	185	$field_name = $pr->getText( $outputmode, $this->mLinker );
Index: trunk/extensions/SemanticResultFormats/GoogleCharts/SRF_GoogleBar.php
—	—	@@ -23,7 +23,7 @@
24	24	return wfMsg( 'srf_printername_googlebar' );
25	25	}
26	26
27		~~- protected function getResultText( $res, $outputmode ) {~~
	27	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
28	28	$this->isHTML = true;
29	29
30	30	$t = "";
Index: trunk/extensions/SemanticResultFormats/GoogleCharts/SRF_GooglePie.php
—	—	@@ -29,7 +29,7 @@
30	30	return wfMsg( 'srf_printername_googlepie' );
31	31	}
32	32
33		~~- protected function getResultText( $res, $outputmode ) {~~
	33	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
34	34	$this->isHTML = true;
35	35
36	36	$t = "";
Index: trunk/extensions/SemanticResultFormats/iCalendar/SRF_iCalendar.php
—	—	@@ -56,7 +56,7 @@
57	57	return wfMsg( 'srf_printername_icalendar' );
58	58	}
59	59
60		~~- protected function getResultText( $res, $outputmode ) {~~
	60	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
61	61	return $outputmode == SMW_OUTPUT_FILE ? $this->getIcal( $res ) : $this->getIcalLink( $res, $outputmode );
62	62	}
63	63
Index: trunk/extensions/SemanticResultFormats/Math/SRF_Math.php
—	—	@@ -21,7 +21,7 @@
22	22	return $wgLang->formatNum( $this->getResultText( $results, SMW_OUTPUT_HTML ) );
23	23	}
24	24
25		~~- protected function getResultText( $res, $outputmode ) {~~
	25	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
26	26	// initialize all necessary variables
27	27	$sum = 0;
28	28	$count = 0;
Index: trunk/extensions/SemanticResultFormats/GraphViz/SRF_Graph.php
—	—	@@ -105,7 +105,7 @@
106	106	}
107	107	}
108	108
109		~~- protected function getResultText( /* SMWQueryResult */ $res, $outputmode ) {~~
	109	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
110	110	global $wgGraphVizSettings;
111	111	$wgGraphVizSettings = new GraphVizSettings;
112	112	$this->isHTML = true;
Index: trunk/extensions/SemanticResultFormats/GraphViz/SRF_Process.php
—	—	@@ -161,7 +161,7 @@
162	162	* @returns String, rendered HTML output of this printer for the ask-query
163	163	*
164	164	*/
165		~~- protected function getResultText( $res, $outputmode ) {~~
	165	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
166	166	global $wgContLang; // content language object
167	167
168	168	//
Index: trunk/extensions/SemanticResultFormats/Exhibit/SRF_Exhibit.php
—	—	@@ -47,7 +47,7 @@
48	48	}
49	49	}
50	50
51		~~- protected function getResultText( $res, $outputmode ) {~~
	51	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
52	52
53	53	global $smwgIQRunningNumber, $wgScriptPath, $wgGoogleMapsKey, $srfgScriptPath;
54	54
Index: trunk/extensions/SemanticResultFormats/vCard/SRF_vCard.php
—	—	@@ -36,7 +36,7 @@
37	37	return wfMsg( 'srf_printername_vcard' );
38	38	}
39	39
40		~~- protected function getResultText( $res, $outputmode ) {~~
	40	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
41	41	global $wgSitename;
42	42	$result = '';
43	43	$items = array();
Index: trunk/extensions/SemanticResultFormats/Gallery/SRF_Gallery.php
—	—	@@ -21,7 +21,7 @@
22	22	return $this->getResultText( $results, SMW_OUTPUT_HTML );
23	23	}
24	24
25		~~- public function getResultText( $results, $outputmode ) {~~
	25	+ public function getResultText( SMWQueryResult $results, $outputmode ) {
26	26	global $wgUser, $wgParser;
27	27
28	28	$ig = new ImageGallery();
Index: trunk/extensions/SemanticResultFormats/TagCloud/SRF_TagCloud.php
—	—	@@ -106,7 +106,7 @@
107	107	$this->maxSize = $params['maxsize'];
108	108	}
109	109
110		~~- public function getResultText( /* SMWQueryResult */ $results, $outputmode ) {~~
	110	+ public function getResultText( SMWQueryResult $results, $outputmode ) {
111	111	return $this->getTagCloud( $this->getTagSizes( $this->getTags( $results, $outputmode ) ) );
112	112	}
113	113
Index: trunk/extensions/SemanticResultFormats/Ploticus/SRF_Ploticus.php
—	—	@@ -86,7 +86,7 @@
87	87	}
88	88	}
89	89
90		~~- protected function getResultText( $res, $outputmode ) {~~
	90	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
91	91	global $smwgIQRunningNumber, $wgUploadDirectory, $wgUploadPath, $wgTitle, $wgScriptPath, $srfgPloticusPath, $srfgEnvSettings;
92	92
93	93	$this->isHTML = true;
Index: trunk/extensions/SemanticResultFormats/Timeline/SRF_Timeline.php
—	—	@@ -56,7 +56,7 @@
57	57	return wfMsg( 'srf_printername_' . $this->mFormat );
58	58	}
59	59
60		~~- protected function getResultText( /* SMWQueryResult */ $res, $outputmode ) {~~
	60	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
61	61	global $smwgIQRunningNumber;
62	62
63	63	$this->includeJS();
Index: trunk/extensions/SemanticResultFormats/Calendar/SRF_Calendar.php
—	—	@@ -55,7 +55,7 @@
56	56	*
57	57	* TODO: split up megamoth
58	58	*/
59		~~- protected function getResultText( $res, $outputmode ) {~~
	59	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
60	60	global $wgUser;
61	61	$skin = $wgUser->getSkin();
62	62
Index: trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotPie.php
—	—	@@ -104,7 +104,7 @@
105	105	$wgOut->addExtensionStyle( "$srfgScriptPath/jqPlot/jquery.jqplot.css" );
106	106	}
107	107
108		~~- protected function getResultText( $res, $outputmode ) {~~
	108	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
109	109	global $wgOut, $wgParser;
110	110
111	111	$wgParser->disableCache();
Index: trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotBar.php
—	—	@@ -135,7 +135,7 @@
136	136	$wgOut->addExtensionStyle( "$srfgScriptPath/jqPlot/jquery.jqplot.css" );
137	137	}
138	138
139		~~- protected function getResultText( $res, $outputmode ) {~~
	139	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
140	140	global $wgOut, $wgParser;
141	141
142	142	$wgParser->disableCache();
Index: trunk/extensions/SemanticResultFormats/BibTeX/SRF_BibTeX.php
—	—	@@ -53,7 +53,7 @@
54	54	return wfMsg( 'srf_printername_bibtex' );
55	55	}
56	56
57		~~- protected function getResultText( $res, $outputmode ) {~~
	57	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
58	58	global $wgSitename;
59	59	$result = '';
60	60	$items = array();
Index: trunk/extensions/SemanticResultFormats/Array/SRF_Array.php
—	—	@@ -115,7 +115,7 @@
116	116	return wfMsg( 'srf_printername_' . $this->mFormat );
117	117	}
118	118
119		~~- protected function getResultText( $res, $outputmode ) {~~
	119	+ protected function getResultText( SMWQueryResult $res, $outputmode ) {
120	120	/*
121	121	* @ToDo:
122	122	* labels of requested properties could define default values. Seems not possible at the moment because

Status & tagging log

09:19, 27 May 2011 Reedy (talk | contribs) changed the status of r88953 [removed: new added: deferred]