r88501 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88500‎ | r88501 | r88502 >
Date:23:36, 20 May 2011
Author:mah
Status:ok (Comments)
Tags:
Comment:
Patch for Bug #29040, “Web installer fails to show help boxes”
fix from William Demchick
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -205,10 +205,13 @@
206206 *
207207 * @return string
208208 */
209 - public function getLanguageSelector( $name, $label, $selectedCode ) {
 209+ public function getLanguageSelector( $name, $label, $selectedCode, $helpHtml = '' ) {
210210 global $wgDummyLanguageCodes;
211 - $s = Html::openElement( 'select', array( 'id' => $name, 'name' => $name ) ) . "\n";
212211
 212+ $s = $helpHtml;
 213+
 214+ $s .= Html::openElement( 'select', array( 'id' => $name, 'name' => $name ) ) . "\n";
 215+
213216 $languages = Language::getLanguageNames();
214217 ksort( $languages );
215218 $dummies = array_flip( $wgDummyLanguageCodes );

Comments

#Comment by 😂 (talk | contribs)   20:50, 19 July 2011

Typo in commit summary, referring to bug 29042.

Status & tagging log