r88403 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88402‎ | r88403 | r88404 >
Date:06:58, 19 May 2011
Author:wikinaut
Status:deferred (Comments)
Tags:
Comment:
test permissions before showing the page
Modified paths:
  • /trunk/extensions/OpenID/OpenID.i18n.php (modified) (history)
  • /trunk/extensions/OpenID/OpenID.setup.php (modified) (history)
  • /trunk/extensions/OpenID/README.OpenID-mediawiki-extension (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDDashboard.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/OpenID.i18n.php
@@ -32,7 +32,7 @@
3333 * @author Thomas Gries
3434 */
3535 $messages['en'] = array(
36 - 'openid-desc' => 'Lets users log in to the wiki with an [http://openid.net/ OpenID] and log in to other OpenID-aware Web sites with their wiki user account',
 36+ 'openid-desc' => 'Let users log in to the wiki with an [http://openid.net/ OpenID]. If this is enabled on the wiki, they can also use their user account url of this wiki as OpenID to log in to other OpenID-aware web sites.',
3737 'openidlogin' => 'Log in with OpenID',
3838 'openidserver' => 'OpenID server',
3939 'openidxrds' => 'Yadis file',
Index: trunk/extensions/OpenID/README.OpenID-mediawiki-extension
@@ -1,9 +1,11 @@
2 -MediaWiki OpenID extension
3 -
4 -homepage and manual http://www.mediawiki.org/wiki/Extension:OpenID
 2+MediaWiki OpenID extension README.OpenID-mediawiki-extension file
53 version 0.921-beta
64 19 May 2011
75
 6+Homepage and manual http://www.mediawiki.org/wiki/Extension:OpenID
 7+
 8+Please check OpenID.setup.php for the current program version number
 9+
810 This is the README file for the OpenID extension for MediaWiki software. The
911 extension is only useful if you've got a MediaWiki installation; it can only be
1012 installed by the administrator of the site.
Index: trunk/extensions/OpenID/OpenID.setup.php
@@ -27,7 +27,7 @@
2828 exit( 1 );
2929 }
3030
31 -define( 'MEDIAWIKI_OPENID_VERSION', '0.921-beta' );
 31+define( 'MEDIAWIKI_OPENID_VERSION', '0.922-beta' );
3232
3333 # CONFIGURATION VARIABLES
3434
Index: trunk/extensions/OpenID/SpecialOpenIDDashboard.body.php
@@ -61,7 +61,13 @@
6262 global $wgOpenIDAllowServingOpenIDUserAccounts;
6363 global $wgOpenIDShowProviderIcons;
6464
 65+ if ( !$wgUser->isAllowed( 'openid-dashboard-access' ) ) {
 66+ $wgOut->permissionRequired( 'openid' );
 67+ return;
 68+ }
 69+
6570 $out = "<table class='openiddashboard wikitable'><tr><th>Parameter</th><th>Value</th></tr>";
 71+ $out .= show( 'MEDIAWIKI_OPENID_VERSION', MEDIAWIKI_OPENID_VERSION );
6672 $out .= show( '$wgOpenIDOnly', $wgOpenIDOnly );
6773 $out .= show( '$wgOpenIDClientOnly', $wgOpenIDClientOnly );
6874 $out .= show( '$wgOpenIDAllowServingOpenIDUserAccounts', $wgOpenIDAllowServingOpenIDUserAccounts );

Follow-up revisions

RevisionCommit summaryAuthorDate
r88434s/url/URL/ and deleted period at msg text endwikinaut22:31, 19 May 2011

Comments

#Comment by Siebrand (talk | contribs)   08:10, 19 May 2011

Extension description should not end with a period, and URL should be all caps.

#Comment by Wikinaut (talk | contribs)   08:25, 19 May 2011

Merci-danke-bedankt-thanks for info, indeed, I was unsure about correctness when I wrote it. I will correct the mentioned issues this evening and study the policies and best practice pages for this (again). Thoroughly. I promise.

#Comment by Siebrand (talk | contribs)   08:45, 19 May 2011

Yay :). Thanks.

#Comment by Wikinaut (talk | contribs)   22:35, 19 May 2011

I don't know if I did this correctly. Done as requested; added the r88434 as follow-up revision and set to "resolved". Is this ok? Pls let me know if not

#Comment by Siebrand (talk | contribs)   23:21, 19 May 2011

It's OK. Thanks.

We agreed to not set our own revisions to OK/resolved. If you think you fixed a FIXME, you should set it back to new. See Code review#Status, last paragraph.

#Comment by Wikinaut (talk | contribs)   23:35, 19 May 2011

This is very reasonable! I still did not read... but now - and http://www.mediawiki.org/wiki/Code_review#Status wikitable-zed that part

Status & tagging log