r88404 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88403‎ | r88404 | r88405 >
Date:13:08, 19 May 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r88394
Modified paths:
  • /trunk/extensions/SemanticWatchlist/SemanticWatchlist.hooks.php (modified) (history)
  • /trunk/extensions/SemanticWatchlist/SemanticWatchlist.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticWatchlist/SemanticWatchlist.i18n.php
@@ -49,10 +49,9 @@
5050 'prefs-swl' => 'Semantic watchlist',
5151 'prefs-swlgroup' => 'Groups to watch',
5252 'prefs-swlnotification' => 'Notification options',
53 - 'swl-prefs-label' => "'''$1''': {{PLURAL:$2|property|properties}} $3 from $4 ''$5''.",
54 - 'swl-prefs-category' => 'category',
55 - 'swl-prefs-namespace' => 'namespace',
56 - 'swl-prefs-concept' => 'concept',
 53+ 'swl-prefs-category-label' => "'''$1''': {{PLURAL:$2|property|properties}} $3 from category ''$4''.",
 54+ 'swl-prefs-namespace-label' => "'''$1''': {{PLURAL:$2|property|properties}} $3 from namespace ''$4''.",
 55+ 'swl-prefs-concept-label' => "'''$1''': {{PLURAL:$2|property|properties}} $3 from concept ''$4''.",
5756 'swl-prefs-emailnofity' => 'E-mail me on changes to properties I am watching'
5857 );
5958
Index: trunk/extensions/SemanticWatchlist/SemanticWatchlist.hooks.php
@@ -102,24 +102,22 @@
103103
104104 switch ( true ) {
105105 case count( $group->getCategories() ) > 0 :
106 - $type = 'swl-prefs-category';
 106+ $type = 'category';
107107 $name = $group->getCategories();
108108 $name = $name[0];
109109 break;
110110 case count( $group->getNamespaces() ) > 0 :
111 - $type = 'swl-prefs-namespace';
 111+ $type = 'namespace';
112112 $name = $group->getNamespaces();
113113 $name = $name[0] == 0 ? wfMsg( 'main' ) : MWNamespace::getCanonicalName( $name[0] );
114114 break;
115115 case count( $group->getConcepts() ) > 0 :
116 - $type = 'swl-prefs-concept';
 116+ $type = 'concept';
117117 $name = $group->getConcepts();
118118 $name = $item[0];
119119 break;
120120 }
121121
122 - $type = wfMsg( $type );
123 -
124122 $properties = $group->getProperties();
125123
126124 foreach ( $properties as &$property ) {
@@ -129,12 +127,11 @@
130128 $preferences['swlwatchgroup-' . $group->getId()] = array(
131129 'type' => 'toggle',
132130 'label' => wfMsgExt(
133 - 'swl-prefs-label',
 131+ "swl-prefs-$type-label",
134132 'parseinline',
135133 $group->getName(),
136134 count( $group->getProperties() ),
137135 $GLOBALS['wgLang']->listToText( $properties ),
138 - $type,
139136 $name
140137 ),
141138 'section' => 'swl/swlgroup',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88394work on semantic watchlist user preferencesjeroendedauw21:47, 18 May 2011

Status & tagging log