r88385 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88384‎ | r88385 | r88386 >
Date:19:36, 18 May 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
Follow-up to r88378 & r88379: move to common/shared.css (appropriate place) and add @noflip
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -576,11 +576,6 @@
577577 #bodyContent a.external:active {
578578 color: #b63;
579579 }
580 -/* External URLs should always be treated as LTR (bug 4330) */
581 -div#content .rtl a.external {
582 - direction: ltr;
583 - unicode-bidi: embed;
584 -}
585580
586581 /*
587582 ** Structural Elements
Index: trunk/phase3/skins/modern/main.css
@@ -644,11 +644,6 @@
645645 #mw_content a.external {
646646 color: #36b;
647647 }
648 -/* External URLs should always be treated as LTR (bug 4330) */
649 -#mw_content .rtl a.external {
650 - direction: ltr;
651 - unicode-bidi: embed;
652 -}
653648
654649
655650 .redirectText {
Index: trunk/phase3/skins/common/shared.css
@@ -298,6 +298,11 @@
299299 background: none !important;
300300 padding: 0 !important;
301301 }
 302+/* External URLs should always be treated as LTR (bug 4330) */
 303+/* @noflip */ .rtl a.external {
 304+ direction: ltr;
 305+ unicode-bidi: embed;
 306+}
302307
303308 /* wikitable class for skinning normal tables
304309 * keep on sync with commonPrint.css
Index: trunk/phase3/skins/vector/screen.css
@@ -1135,11 +1135,6 @@
11361136 div#content a.external:active {
11371137 color: #b63;
11381138 }
1139 -/* External URLs should always be treated as LTR (bug 4330) */
1140 -div#content .rtl a.external {
1141 - direction: ltr;
1142 - unicode-bidi: embed;
1143 -}
11441139
11451140
11461141 div#content .printfooter {

Follow-up revisions

RevisionCommit summaryAuthorDate
r88386Per discussion, only apply to .free and .autonumber (so custom link texts are...robin19:44, 18 May 2011
r88413Add release note for fixing bug 4330 (r88385)robin17:09, 19 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88378(bug 4330) External URLs should always be treated as LTR, also in RTL text (C...robin18:03, 18 May 2011
r88379fix r88378: fix CSS id in modern skinrobin18:10, 18 May 2011

Comments

#Comment by Siebrand (talk | contribs)   23:15, 18 May 2011

This needs an update of release notes.

#Comment by SPQRobin (talk | contribs)   17:09, 19 May 2011

Done in r88413.

Status & tagging log