r88378 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88377‎ | r88378 | r88379 >
Date:18:03, 18 May 2011
Author:robin
Status:resolved (Comments)
Tags:
Comment:
(bug 4330) External URLs should always be treated as LTR, also in RTL text (CSS fix thanks to Amir Aharoni)
Modified paths:
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -576,6 +576,11 @@
577577 #bodyContent a.external:active {
578578 color: #b63;
579579 }
 580+/* External URLs should always be treated as LTR (bug 4330) */
 581+div#content .rtl a.external {
 582+ direction: ltr;
 583+ unicode-bidi: embed;
 584+}
580585
581586 /*
582587 ** Structural Elements
Index: trunk/phase3/skins/modern/main.css
@@ -644,9 +644,13 @@
645645 #mw_content a.external {
646646 color: #36b;
647647 }
 648+/* External URLs should always be treated as LTR (bug 4330) */
 649+div#content .rtl a.external {
 650+ direction: ltr;
 651+ unicode-bidi: embed;
 652+}
648653
649654
650 -
651655 .redirectText {
652656 font-size: 150%;
653657 margin: 5px;
Index: trunk/phase3/skins/vector/screen.css
@@ -1135,6 +1135,11 @@
11361136 div#content a.external:active {
11371137 color: #b63;
11381138 }
 1139+/* External URLs should always be treated as LTR (bug 4330) */
 1140+div#content .rtl a.external {
 1141+ direction: ltr;
 1142+ unicode-bidi: embed;
 1143+}
11391144
11401145
11411146 div#content .printfooter {

Follow-up revisions

RevisionCommit summaryAuthorDate
r88379fix r88378: fix CSS id in modern skinrobin18:10, 18 May 2011
r88385Follow-up to r88378 & r88379: move to common/shared.css (appropriate place) a...robin19:36, 18 May 2011
r88413Add release note for fixing bug 4330 (r88385)robin17:09, 19 May 2011

Comments

#Comment by Krinkle (talk | contribs)   18:25, 18 May 2011

External links exist of three types:

  • Clear text
    http://mediawiki.org
    [http://mediawiki.org http://mediawiki.org]
  • Custom title
    click here
    [http://mediawiki.org click here]
  • Numeral counter
    [1]
    [http://mediawiki.org]

This commit braks the latter two since it forces LTR for no reason.

Also, there is auto-flipping in MediaWiki's resource loader. If you want CSS rules to only apply to a certain direction use the directional selector and add @noflip.

#Comment by SPQRobin (talk | contribs)   19:46, 18 May 2011

Moved to shared.css (with @noflip) in r88385 and only applied to .free and .autonumber so it doesn't break custom titles, in r88386.

Status & tagging log