r88024 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88023‎ | r88024 | r88025 >
Date:23:18, 13 May 2011
Author:freakolowsky
Status:reverted (Comments)
Tags:
Comment:
* partial revert of r88019. Left the messages in for now ... don't know ... those mesages seem logical to me, i know domas might not like it, but they are still displayed.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -772,9 +772,9 @@
773773 */
774774 function getSqlComment() {
775775 if ( $this->namespace || $this->deletedOnly ) {
776 - return wfMsg( 'sp-contributions-filtered' ); // potentially slow, see CR r58153
 776+ return 'contributions page filtered for namespace or RevisionDeleted edits'; // potentially slow, see CR r58153
777777 } else {
778 - return wfMsg( 'sp-contributions-unfiltered' );
 778+ return 'contributions page unfiltered';
779779 }
780780 }
781781

Follow-up revisions

RevisionCommit summaryAuthorDate
r96306Revert r88008 (add size difference to Special:Contributions) and its large gr...catrope21:47, 5 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88019* fixed as per comment on r88008freakolowsky21:33, 13 May 2011

Comments

#Comment by Nikerabbit (talk | contribs)   08:35, 14 May 2011

Where are they displayed?

#Comment by Freakolowsky (talk | contribs)   08:46, 14 May 2011

/me hides ... was looking at some other comments ... was reverted in next rev

Status & tagging log