r88019 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88018‎ | r88019 | r88020 >
Date:21:33, 13 May 2011
Author:freakolowsky
Status:reverted (Comments)
Tags:
Comment:
* fixed as per comment on r88008
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -735,15 +735,7 @@
736736
737737 $diffHistLinks = '(' . $difftext . $this->messages['pipe-separator'] . $histlink . ')';
738738
739 - $calculatedSize = $row->rc_new_len - $row->rc_old_len;
740 - $diffOut = ' . . ';
741 - if ( $calculatedSize === 0 ) {
742 - $diffOut .= "<span class='mw-plusminus-null'>($calculatedSize)</span>";
743 - } elseif ( $calculatedSize > 0 ) {
744 - $diffOut .= "<span class='mw-plusminus-pos'>(+$calculatedSize)</span>";
745 - } else {
746 - $diffOut .= "<span class='mw-plusminus-neg'>($calculatedSize)</span>";
747 - }
 739+ $diffOut = ' . . '.ChangesList::showCharacterDifference( $row->rc_old_len, $row->rc_new_len );
748740
749741 $ret = "{$del}{$d} {$diffHistLinks} {$nflag}{$mflag} {$link}{$diffOut}{$userlink} {$comment} {$topmarktext}";
750742
@@ -780,9 +772,9 @@
781773 */
782774 function getSqlComment() {
783775 if ( $this->namespace || $this->deletedOnly ) {
784 - return 'contributions page filtered for namespace or RevisionDeleted edits'; // potentially slow, see CR r58153
 776+ return wfMsg( 'sp-contributions-filtered' ); // potentially slow, see CR r58153
785777 } else {
786 - return 'contributions page unfiltered';
 778+ return wfMsg( 'sp-contributions-unfiltered' );
787779 }
788780 }
789781
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2992,6 +2992,8 @@
29932993 'sp-contributions-explain' => '', # only translate this message to other languages if you have to change it
29942994 'sp-contributions-footer' => '-', # do not translate or duplicate this message to other languages
29952995 'sp-contributions-footer-anon' => '-', # do not translate or duplicate this message to other languages
 2996+'sp-contributions-filtered' => 'contributions page filtered for namespace or RevisionDeleted edits',
 2997+'sp-contributions-unfiltered' => 'contributions page unfiltered',
29962998
29972999 # What links here
29983000 'whatlinkshere' => 'What links here',

Follow-up revisions

RevisionCommit summaryAuthorDate
r88024* partial revert of r88019. Left the messages in for now ... don't know ... t...freakolowsky23:18, 13 May 2011
r96306Revert r88008 (add size difference to Special:Contributions) and its large gr...catrope21:47, 5 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88008* bug 24037freakolowsky17:11, 13 May 2011

Comments

#Comment by Nikerabbit (talk | contribs)   21:37, 13 May 2011

Translating SQL comments?

#Comment by Freakolowsky (talk | contribs)   22:36, 13 May 2011

Yeah ... if i manage to do that Siebrand will be out of job :D

#Comment by Platonides (talk | contribs)   22:47, 13 May 2011

I don't think people like Domas would enjoy getting a SQL comment in Chinese (when trying to do real work).

#Comment by Freakolowsky (talk | contribs)   05:51, 22 June 2011

Aaron ... why fixme? ... it was resolved in later followups.

#Comment by Aaron Schulz (talk | contribs)   15:07, 22 June 2011

Seems it was.

Status & tagging log