r88004 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88003‎ | r88004 | r88005 >
Date:16:21, 13 May 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
(bug 10154) Don't allow user to specify days beyond $wgRCMaxAge
Modified paths:
  • /trunk/phase3/includes/AjaxFunctions.php (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/AjaxFunctions.php
@@ -83,19 +83,3 @@
8484
8585 return '';
8686 }
87 -
88 -/**
89 - * Called in some places (currently just extensions)
90 - * to get the URL for a given file.
91 - */
92 -function wfAjaxGetFileUrl( $file ) {
93 - $file = wfFindFile( $file );
94 -
95 - if ( !$file || !$file->exists() ) {
96 - return null;
97 - }
98 -
99 - $url = $file->getUrl();
100 -
101 - return $url;
102 -}
Index: trunk/phase3/includes/DefaultSettings.php
@@ -5185,7 +5185,7 @@
51865186 * List of Ajax-callable functions.
51875187 * Extensions acting as Ajax callbacks must register here
51885188 */
5189 -$wgAjaxExportList = array( 'wfAjaxGetFileUrl' );
 5189+$wgAjaxExportList = array();
51905190
51915191 /**
51925192 * Enable watching/unwatching pages using AJAX.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87545(bug 10154) Don't allow user to specify days beyond $wgRCMaxAgedemon15:45, 6 May 2011

Comments

#Comment by 😂 (talk | contribs)   16:22, 13 May 2011

Didn't press save. Summary was:

"Kill another ajax function: wfAjaxGetFileUrl() was only used in Configure, and isn't doing it in trunk anymore. Can we kill this now, please?"

#Comment by 😂 (talk | contribs)   16:24, 13 May 2011

No, we can't kill it. Dozens of users in /trunk/extensions :(

#Comment by Hashar (talk | contribs)   08:38, 14 May 2011

Doesn't it mean mean this r88004 should be reverted? :b

#Comment by 😂 (talk | contribs)   16:08, 14 May 2011

No, I mean killing $wgAjaxExportList in general, not this specific one.

#Comment by IAlex (talk | contribs)   16:22, 13 May 2011

I am not sure that is the correct commit summary ;)

Status & tagging log