r88003 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88002‎ | r88003 | r88004 >
Date:16:16, 13 May 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix unused variables

Decapitalise False
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/ZipDirectoryReader.php (modified) (history)
  • /trunk/phase3/skins/Standard.php (modified) (history)
  • /trunk/phase3/tests/selenium/suites/AddContentToNewPageTestCase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Standard.php
@@ -120,7 +120,7 @@
121121 unset( $bar['TOOLBOX'] );
122122
123123 $barnumber = 1;
124 - foreach ( $bar as $heading => $browseLinks ) {
 124+ foreach ( $bar as $browseLinks ) {
125125 if ( $barnumber > 1 ) {
126126 $s .= "\n<hr class='sep' />";
127127 }
Index: trunk/phase3/tests/selenium/suites/AddContentToNewPageTestCase.php
@@ -114,8 +114,8 @@
115115
116116 // Add level 2 headline and verify output in the preview
117117 public function testAddLevel2HeadLine() {
118 - $blnElementPresent = False;
119 - $blnTextPresent = False;
 118+ $blnElementPresent = false;
 119+ $blnTextPresent = false;
120120 $this->getExistingPage();
121121 $this->clickEditLink();
122122 $this->loadWikiEditor();
Index: trunk/phase3/includes/Article.php
@@ -1733,7 +1733,7 @@
17341734 * or else the record will be left in a funky state.
17351735 * Best if all done inside a transaction.
17361736 *
1737 - * @param $dbw Database
 1737+ * @param $dbw DatabaseBase
17381738 * @return int The newly created page_id key, or false if the title already existed
17391739 * @private
17401740 */
Index: trunk/phase3/includes/ZipDirectoryReader.php
@@ -16,8 +16,8 @@
1717 * suspicious or ambiguous input, instead of emulating some standard
1818 * behaviour.
1919 *
20 - * @param $fileName The archive file name
21 - * @param $callback The callback function. It will be called for each file
 20+ * @param $fileName string The archive file name
 21+ * @param $callback Array The callback function. It will be called for each file
2222 * with a single associative array each time, with members:
2323 *
2424 * - name: The file name. Directories conventionally have a trailing
@@ -27,7 +27,7 @@
2828 *
2929 * - size: The uncompressed file size
3030 *
31 - * @param $options An associative array of read options, with the option
 31+ * @param $options Array An associative array of read options, with the option
3232 * name in the key. This may currently contain:
3333 *
3434 * - zip64: If this is set to true, then we will emulate a
@@ -44,7 +44,7 @@
4545 * valid ZIP64 file, and working out what non-ZIP64 readers will make
4646 * of such a file is not trivial.
4747 *
48 - * @return A Status object. The following fatal errors are defined:
 48+ * @return Status object. The following fatal errors are defined:
4949 *
5050 * - zip-file-open-error: The file could not be opened.
5151 *
@@ -119,6 +119,8 @@
120120
121121 /**
122122 * Read the directory according to settings in $this.
 123+ *
 124+ * @return Status
123125 */
124126 function execute() {
125127 $this->file = fopen( $this->fileName, 'r' );

Status & tagging log