r88002 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88001‎ | r88002 | r88003 >
Date:16:16, 13 May 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Improve variable naming
Modified paths:
  • /trunk/phase3/includes/api/ApiComparePages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiComparePages.php
@@ -63,13 +63,13 @@
6464 * @param $title string
6565 * @return int
6666 */
67 - private function revisionOrTitle( $revision, $title ) {
 67+ private function revisionOrTitle( $revision, $titleText ) {
6868 if( $revision ){
6969 return $revision;
70 - } elseif( $title ) {
71 - $title = Title::newFromText( $title );
 70+ } elseif( $titleText ) {
 71+ $title = Title::newFromText( $titleText );
7272 if( !$title ){
73 - $this->dieUsageMsg( array( 'invalidtitle', $title ) );
 73+ $this->dieUsageMsg( array( 'invalidtitle', $titleText ) );
7474 }
7575 return $title->getLatestRevID();
7676 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r88033Followup r88002, fix naming on param documentationreedy09:05, 14 May 2011

Comments

#Comment by Hashar (talk | contribs)   08:40, 14 May 2011

You forgot to update the documentation block!

Status & tagging log